New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: Add more tests for FormulaAudit/Miscellaneous cop #3144

Merged
merged 1 commit into from Sep 22, 2017

Conversation

Projects
None yet
3 participants
@GauthamGoli
Member

GauthamGoli commented Sep 10, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

#3091

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Sep 22, 2017

Member

Hooray for more tests 🎉! Thanks again @GauthamGoli!

Member

MikeMcQuaid commented Sep 22, 2017

Hooray for more tests 🎉! Thanks again @GauthamGoli!

@MikeMcQuaid MikeMcQuaid merged commit 199aa95 into Homebrew:master Sep 22, 2017

3 checks passed

codecov/patch Coverage not affected when comparing dbc4a38...626cb6c
Details
codecov/project 67.11% (+11.56%) compared to dbc4a38
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.