New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `brew cask search` spec deterministic. #3145

Merged
merged 1 commit into from Sep 10, 2017

Conversation

Projects
None yet
1 participant
@reitermarkus
Member

reitermarkus commented Sep 10, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

There is a new Cask called dynamodb-local which results in these tests failing.

@reitermarkus reitermarkus merged commit 8f8f0f0 into Homebrew:master Sep 10, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 455ec4c...194a2c2
Details
codecov/project 50.75% (+1.17%) compared to 455ec4c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reitermarkus reitermarkus deleted the reitermarkus:cask-search branch Sep 10, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.