New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Cask commands fail early if a Cask is not found. #3146

Merged
merged 1 commit into from Sep 11, 2017

Conversation

Projects
None yet
3 participants
@reitermarkus
Member

reitermarkus commented Sep 11, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Fixes Homebrew/homebrew-cask#38304.

@reitermarkus reitermarkus requested a review from vitorgalvao Sep 11, 2017

@reitermarkus reitermarkus merged commit da742d8 into Homebrew:master Sep 11, 2017

3 checks passed

codecov/patch 76.92% of diff hit (target 67.06%)
Details
codecov/project 67.09% (+0.03%) compared to f3ec40d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@leipert

This comment has been minimized.

Show comment
Hide comment
@leipert

leipert Sep 12, 2017

@reitermarkus This line seems to throw an error, if I run brew cask _appcast_checkpoint gogland --calculate:

Error: undefined local variable or method `load_casks' for #<Hbc::CLI::InternalAppcastCheckpoint:0x007f97ca86d490>
Follow the instructions here:
  https://github.com/caskroom/homebrew-cask#reporting-bugs
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/internal_appcast_checkpoint.rb:15:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/abstract_command.rb:35:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:97:in `run_command'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:167:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:131:in `run'
/usr/local/Homebrew/Library/Homebrew/cmd/cask.rb:8:in `cask'
/usr/local/Homebrew/Library/Homebrew/brew.rb:95:in `<main>'

@reitermarkus This line seems to throw an error, if I run brew cask _appcast_checkpoint gogland --calculate:

Error: undefined local variable or method `load_casks' for #<Hbc::CLI::InternalAppcastCheckpoint:0x007f97ca86d490>
Follow the instructions here:
  https://github.com/caskroom/homebrew-cask#reporting-bugs
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/internal_appcast_checkpoint.rb:15:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/abstract_command.rb:35:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:97:in `run_command'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:167:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:131:in `run'
/usr/local/Homebrew/Library/Homebrew/cmd/cask.rb:8:in `cask'
/usr/local/Homebrew/Library/Homebrew/brew.rb:95:in `<main>'

This comment has been minimized.

Show comment
Hide comment
@reitermarkus

reitermarkus Sep 12, 2017

Member

Thanks, this must have slipped through my search-and-replace.

Member

reitermarkus replied Sep 12, 2017

Thanks, this must have slipped through my search-and-replace.

This comment has been minimized.

Show comment
Hide comment
@leipert

leipert Sep 12, 2017

No worries, thanks for fixing it fast :)

leipert replied Sep 12, 2017

No worries, thanks for fixing it fast :)

@reitermarkus reitermarkus deleted the reitermarkus:cask-fail-early branch Apr 15, 2018

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.