New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uninstall with `:signal`. #3148

merged 1 commit into from Sep 12, 2017


None yet
2 participants

reitermarkus commented Sep 11, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Fixes Homebrew/homebrew-cask#38486.

@reitermarkus reitermarkus requested a review from vitorgalvao Sep 11, 2017

@reitermarkus reitermarkus merged commit becd8d8 into Homebrew:master Sep 12, 2017

3 checks passed

codecov/patch 83.33% of diff hit (target 67.09%)
codecov/project 67.09% (+<.01%) compared to da742d8
continuous-integration/travis-ci/pr The Travis CI build passed

@reitermarkus reitermarkus deleted the reitermarkus:uninstall-signal branch Sep 12, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.