New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

superenv: help Autotools with 10.13 SDK on 10.12 #3182

Merged
merged 1 commit into from Sep 21, 2017
Jump to file or symbol
Failed to load files and symbols.
+6 −3
Diff settings

Always

Just for now

@@ -96,9 +96,12 @@ def setup_build_environment(formula = nil)
self["SDKROOT"] = MacOS.sdk_path
end
# Filter out symbols known not to be defined on 10.11 since GNU Autotools
# can't reliably figure this out with Xcode 8 on its own yet.
if MacOS.version == "10.11" && MacOS::Xcode.installed? && MacOS::Xcode.version >= "8.0"
# Filter out symbols known not to be defined since GNU Autotools can't
# reliably figure this out with Xcode 8 and above.
if MacOS.version == "10.12" && MacOS::Xcode.installed? && MacOS::Xcode.version >= "9.0"
ENV["ac_cv_func_futimens"] = "no"
ENV["ac_cv_func_utimensat"] = "no"

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Sep 21, 2017

Member

If there's any more in a future PR let's make this a loop like below.

elsif MacOS.version == "10.11" && MacOS::Xcode.installed? && MacOS::Xcode.version >= "8.0"
%w[basename_r clock_getres clock_gettime clock_settime dirname_r
getentropy mkostemp mkostemps timingsafe_bcmp].each do |s|
ENV["ac_cv_func_#{s}"] = "no"
ProTip! Use n and p to navigate between commits in a pull request.