New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a failure message to be_detected_from matcher #3186

Merged
merged 2 commits into from Sep 22, 2017

Conversation

Projects
None yet
2 participants
@naoty
Contributor

naoty commented Sep 22, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

I added a failure message to #be_detected_from matcher because I was not sure what is wrong in tests.

Before

Failures:

  1) Version::detect version all dots
     Failure/Error:
       expect(Version.create("1.13"))
         .to be_detected_from("http://example.com/foo.bar.la.1.14.zip")

       expected #<Version:0x00000101c18de0 @version="1.13", @tokens=[#<Version::NumericToken 1>, #<Version::NumericToken 13>]> to be detected from "http://example.com/foo.bar.la.1.14.zip"

After

Failures:

  1) Version::detect version all dots
     Failure/Error:
       expect(Version.create("1.13"))
         .to be_detected_from("http://example.com/foo.bar.la.1.14.zip")

               expected: 1.13
               detected: 1.14
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Sep 22, 2017

Member

Thanks again for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

Member

MikeMcQuaid commented Sep 22, 2017

Thanks again for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

@MikeMcQuaid MikeMcQuaid merged commit 0464869 into Homebrew:master Sep 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@naoty naoty deleted the naoty:detect-failure-message branch Sep 23, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.