New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail if no default language is specified. #3195

merged 1 commit into from Sep 29, 2017


None yet
2 participants

reitermarkus commented Sep 22, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Fixes Homebrew/homebrew-cask#38593.

@reitermarkus reitermarkus requested a review from vitorgalvao Sep 23, 2017

@reitermarkus reitermarkus merged commit 22e329f into Homebrew:master Sep 29, 2017

1 of 3 checks passed

codecov/patch 66.66% of diff hit (target 67.08%)
codecov/project 67.08% (-0.01%) compared to 06b9ab5
continuous-integration/travis-ci/pr The Travis CI build passed

@reitermarkus reitermarkus deleted the reitermarkus:fix-language_eval branch Sep 29, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.