New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cask dsl caveats: bump java version to 9 #3198

Merged
merged 1 commit into from Sep 28, 2017

Conversation

Projects
None yet
3 participants
@commitay
Member

commitay commented Sep 23, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

/cc @vitorgalvao @reitermarkus

@commitay commitay referenced this pull request Sep 23, 2017

Closed

Tracking Java 1.9 Cask updates #38574

7 of 7 tasks complete

@commitay commitay changed the title from Cask dsl caveats: bump java version to Cask dsl caveats: bump java version to 9 Sep 24, 2017

@ilovezfs ilovezfs closed this Sep 27, 2017

@ilovezfs ilovezfs reopened this Sep 27, 2017

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Sep 27, 2017

Contributor

@commitay can you rebase this on master please

Contributor

ilovezfs commented Sep 27, 2017

@commitay can you rebase this on master please

@commitay

This comment has been minimized.

Show comment
Hide comment
@commitay

commitay Sep 27, 2017

Member

Rebased.

Member

commitay commented Sep 27, 2017

Rebased.

@vitorgalvao vitorgalvao merged commit 06b9ab5 into Homebrew:master Sep 28, 2017

2 of 3 checks passed

codecov/patch 0% of diff hit (target 67.08%)
Details
codecov/project 67.08% remains the same compared to cb139ca
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@commitay commitay deleted the commitay:cask-java-caveats branch Sep 29, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.