New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: don't check for homebrew/science duplicates #3202

Merged
merged 1 commit into from Sep 24, 2017

Conversation

Projects
None yet
3 participants
@ilovezfs
Contributor

ilovezfs commented Sep 24, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

It's just noise to turn the migration PRs red over expected duplicates.

audit: don't check for homebrew/science duplicates
It's just noise to turn the migration PRs red over expected duplicates.
@apjanke

👍

CI failures look unrelated to me.

@ilovezfs ilovezfs merged commit 4f9c7ca into Homebrew:master Sep 24, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

ilovezfs added a commit to ilovezfs/brew that referenced this pull request Sep 24, 2017

@@ -419,6 +419,7 @@ def audit_formula_name
@@local_official_taps_name_map ||= Tap.select(&:official?).flat_map(&:formula_names)
.each_with_object({}) do |tap_formula_full_name, name_map|
next if tap_formula_full_name.start_with?("homebrew/science/")

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Sep 24, 2017

Member

Arguably we could just kill these checks entirely given we're wanting to move more and more stuff from taps to core. Thoughts?

@MikeMcQuaid

MikeMcQuaid Sep 24, 2017

Member

Arguably we could just kill these checks entirely given we're wanting to move more and more stuff from taps to core. Thoughts?

This comment has been minimized.

@ilovezfs

ilovezfs Sep 24, 2017

Contributor

Yeah. If anything, duplicates in non-Homebrew taps would be more pertinent information at this point.

@ilovezfs

ilovezfs Sep 24, 2017

Contributor

Yeah. If anything, duplicates in non-Homebrew taps would be more pertinent information at this point.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.