New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: also skip homebrew/science duplicates found by search_taps #3203

Merged
merged 1 commit into from Sep 24, 2017

Conversation

Projects
None yet
2 participants
@ilovezfs
Contributor

ilovezfs commented Sep 24, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

#3202 only skips them if homebrew/science is tapped.

@apjanke

This comment has been minimized.

Show comment
Hide comment
@apjanke

apjanke Sep 24, 2017

Contributor

LGTM.

I tested locally by untapping homebrew/science and auditing the imported gdcm from PR Homebrew/homebrew-core#18352.

Before:

$ brew audit --strict --online gdcm
gdcm:
  * Formula name conflicts with homebrew/science/gdcm
  * 'revision 1' should be removed
Error: 2 problems in 1 formula

After:

$ brew audit --strict --online gdcm
gdcm:
  * 'revision 1' should be removed
Error: 1 problem in 1 formula

As expected.

Looks fine with homebrew/science tapped, too.

Contributor

apjanke commented Sep 24, 2017

LGTM.

I tested locally by untapping homebrew/science and auditing the imported gdcm from PR Homebrew/homebrew-core#18352.

Before:

$ brew audit --strict --online gdcm
gdcm:
  * Formula name conflicts with homebrew/science/gdcm
  * 'revision 1' should be removed
Error: 2 problems in 1 formula

After:

$ brew audit --strict --online gdcm
gdcm:
  * 'revision 1' should be removed
Error: 1 problem in 1 formula

As expected.

Looks fine with homebrew/science tapped, too.

@ilovezfs ilovezfs merged commit cd1cb70 into Homebrew:master Sep 24, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.