New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump-formula-pr: fix duplicates check #3214

Merged
merged 1 commit into from Sep 26, 2017

Conversation

Projects
None yet
2 participants
@ilovezfs
Contributor

ilovezfs commented Sep 26, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

return unless pull_requests && !pull_requests.empty? and
return unless pull_requests&.empty? are not equivalent.

Fixes a bug introduced by #3183
that led to bump-formula-pr claiming there were duplcate PRs when there
were none.

bump-formula-pr: fix duplicates check
`return unless pull_requests && !pull_requests.empty?` and
`return unless pull_requests&.empty?` are not equivalent.
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Sep 26, 2017

Member

Thanks for the quick fix @ilovezfs and sorry for the breakage.

Member

MikeMcQuaid commented Sep 26, 2017

Thanks for the quick fix @ilovezfs and sorry for the breakage.

@MikeMcQuaid MikeMcQuaid merged commit 24d7475 into Homebrew:master Sep 26, 2017

1 of 3 checks passed

codecov/patch 0% of diff hit (target 67.05%)
Details
codecov/project 67.05% (-0.01%) compared to 6098998
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.