New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --language to brew-cask manpage #3221

Merged
merged 1 commit into from Sep 29, 2017

Conversation

Projects
None yet
3 participants
@yzguy
Contributor

yzguy commented Sep 27, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Fixes: Homebrew/homebrew-cask#31129

Add --language to various parts of manpage for brew-cask

Any feedback/criticism is appreciated :)

@reitermarkus

This comment has been minimized.

Show comment
Hide comment
@reitermarkus

reitermarkus Sep 27, 2017

Member

You need to edit the .md file and then run brew man to regenerate the man page.

Member

reitermarkus commented Sep 27, 2017

You need to edit the .md file and then run brew man to regenerate the man page.

Show outdated Hide outdated manpages/brew-cask.1 Outdated

@reitermarkus reitermarkus self-assigned this Sep 27, 2017

@yzguy

This comment has been minimized.

Show comment
Hide comment
@yzguy

yzguy Sep 28, 2017

Contributor

Updated the .md file, ran brew man to generate the manpage. A lot simpler than writing the manpage syntax yourself :)

Contributor

yzguy commented Sep 28, 2017

Updated the .md file, ran brew man to generate the manpage. A lot simpler than writing the manpage syntax yourself :)

@yzguy

This comment has been minimized.

Show comment
Hide comment
@yzguy

yzguy Sep 29, 2017

Contributor

Done. I squashed all the commits to one. Thanks :)

Contributor

yzguy commented Sep 29, 2017

Done. I squashed all the commits to one. Thanks :)

Feedback has been addressed.

@reitermarkus reitermarkus merged commit d07b6b6 into Homebrew:master Sep 29, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 06b9ab5...9383063
Details
codecov/project 67.08% remains the same compared to 06b9ab5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reitermarkus

This comment has been minimized.

Show comment
Hide comment
@reitermarkus

reitermarkus Sep 29, 2017

Member

Thanks, @yzguy!

Member

reitermarkus commented Sep 29, 2017

Thanks, @yzguy!

@yzguy yzguy deleted the yzguy:asmith/cask-language-manpage branch Sep 29, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.