New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `brew tests` leaving last file in trash. #3247

Merged
merged 2 commits into from Oct 2, 2017

Conversation

Projects
None yet
3 participants
@reitermarkus
Member

reitermarkus commented Sep 30, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Fixes #2974 (comment).

@reitermarkus reitermarkus referenced this pull request Sep 30, 2017

Closed

brew tests invokes "trash" noise. #2974

4 of 4 tasks complete
end if
end repeat
return output
end tell
end run
EOS
# Remove AppleScript's automatic newline.
result.tap { |r| r.stdout.sub!(/\n$/, "") }

This comment has been minimized.

@ilovezfs

ilovezfs Oct 1, 2017

Contributor

chomp! doesn't work?

@ilovezfs

ilovezfs Oct 1, 2017

Contributor

chomp! doesn't work?

This comment has been minimized.

@reitermarkus

reitermarkus Oct 1, 2017

Member

chomp doesn't work on the \r\n edge case.

@reitermarkus

reitermarkus Oct 1, 2017

Member

chomp doesn't work on the \r\n edge case.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 1, 2017

Member

@reitermarkus This is still not fixing #2974. Please guard this test for ENV["CI"] or something similar or I'm just going to remove the test entirely within a few days.

Member

MikeMcQuaid commented Oct 1, 2017

@reitermarkus This is still not fixing #2974. Please guard this test for ENV["CI"] or something similar or I'm just going to remove the test entirely within a few days.

@reitermarkus

This comment has been minimized.

Show comment
Hide comment
@reitermarkus

reitermarkus Oct 1, 2017

Member

Guarded it with HOMEBREW_TESTS_COVERAGE.

Member

reitermarkus commented Oct 1, 2017

Guarded it with HOMEBREW_TESTS_COVERAGE.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid
Member

MikeMcQuaid commented Oct 2, 2017

Thanks @reitermarkus!

@reitermarkus reitermarkus merged commit 23da0aa into Homebrew:master Oct 2, 2017

3 checks passed

codecov/patch 100% of diff hit (target 67.14%)
Details
codecov/project 67.14% (+<.01%) compared to 55dd44e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reitermarkus reitermarkus deleted the reitermarkus:fix-trash branch Oct 2, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.