New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shims/super/make: don't export MAKE=make. #3252

Merged
merged 1 commit into from Oct 1, 2017

Conversation

Projects
None yet
2 participants
@MikeMcQuaid
Member

MikeMcQuaid commented Oct 1, 2017

This is redundant and breaks Handbrake:
HandBrake/HandBrake#872

Changes part of #2877

CC @ilovezfs, @xu-cheng and @mistydemeo FYI

shims/super/make: don't export MAKE=make.
This is redundant and breaks Handbrake:
HandBrake/HandBrake#872

@ilovezfs ilovezfs merged commit 533ea9d into Homebrew:master Oct 1, 2017

3 checks passed

codecov/patch Coverage not affected when comparing d62d496...3343d79
Details
codecov/project 67.14% (+0.01%) compared to d62d496
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:no-export-default-make branch Dec 31, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.