New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor `cask/cli` specs. #3260

Merged
merged 1 commit into from Oct 4, 2017

Conversation

Projects
None yet
2 participants
@reitermarkus
Member

reitermarkus commented Oct 3, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?
@claui

claui approved these changes Oct 3, 2017

Looks good to me! 👍

@reitermarkus reitermarkus merged commit 67afb6e into Homebrew:master Oct 4, 2017

3 checks passed

codecov/patch Coverage not affected when comparing ec0d8fa...643b2a1
Details
codecov/project 67.16% (+0.02%) compared to ec0d8fa
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reitermarkus reitermarkus deleted the reitermarkus:cask-cli-specs branch Oct 4, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.