New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version detection support for php URL #3262

Merged
merged 2 commits into from Oct 6, 2017

Conversation

Projects
None yet
4 participants
@kabel
Contributor

kabel commented Oct 4, 2017

Pulls a semver from anywhere in the URL (not just stem).

Add version detection support for php URL
Pulls a semver from anywhere in the URL (not just stem).
@ilovezfs

Please also add a test or tests. See #2827 and #2931 for examples.

test added

@JCount

JCount approved these changes Oct 4, 2017

@MikeMcQuaid MikeMcQuaid merged commit dd2083d into Homebrew:master Oct 6, 2017

3 checks passed

codecov/patch 100% of diff hit (target 67.12%)
Details
codecov/project 67.14% (+0.01%) compared to 7ee86cf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 6, 2017

Member

Thanks for your contribution to Homebrew/brew, @kabel! Without people like you submitting PRs we couldn't run this project. You rock!

Member

MikeMcQuaid commented Oct 6, 2017

Thanks for your contribution to Homebrew/brew, @kabel! Without people like you submitting PRs we couldn't run this project. You rock!

@kabel kabel deleted the kabel:version-detect-php branch Oct 6, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.