New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing link to CODE_OF_CONDUCT.md within CONTRIBUTING.md #3266

Merged
merged 1 commit into from Oct 5, 2017

Conversation

Projects
None yet
4 participants
@codylewis

codylewis commented Oct 4, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

On https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md the link to the Code of Conduct page leads to a 404 page.

Updating the link allows a user to navigate to the correct page to view the resource.

@JCount

This comment has been minimized.

Show comment
Hide comment
@JCount

JCount Oct 4, 2017

Member

@pseudocody Could you squash these two commits together and then force push? Thanks.

Member

JCount commented Oct 4, 2017

@pseudocody Could you squash these two commits together and then force push? Thanks.

@codylewis

This comment has been minimized.

Show comment
Hide comment
@codylewis

codylewis commented Oct 4, 2017

@JCount updated

@JCount

This comment has been minimized.

Show comment
Hide comment
@JCount

JCount Oct 4, 2017

Member

@pseudocody One last request, I promise. 🤞
Could you switch it to using https://github.com/Homebrew/brew/blob/master/CODE_OF_CONDUCT.md#code-of-conduct as the url. The #code-of-conduct href nicely points directly to the beginning of the actual text of the Code of Conduct. 😄

Member

JCount commented Oct 4, 2017

@pseudocody One last request, I promise. 🤞
Could you switch it to using https://github.com/Homebrew/brew/blob/master/CODE_OF_CONDUCT.md#code-of-conduct as the url. The #code-of-conduct href nicely points directly to the beginning of the actual text of the Code of Conduct. 😄

Cody Lewis
fixed link to CODE_OF_CONDUCT.md within CONTRIBUTING.md
fixed link url to navigate to main brew repo instead of forked repo
@codylewis

This comment has been minimized.

Show comment
Hide comment
@codylewis

codylewis commented Oct 4, 2017

@JCount updated 😃

@JCount

This comment has been minimized.

Show comment
Hide comment
@JCount

JCount Oct 4, 2017

Member

Thanks! 💯 😄

Member

JCount commented Oct 4, 2017

Thanks! 💯 😄

@JCount

JCount approved these changes Oct 4, 2017

@MikeMcQuaid MikeMcQuaid merged commit 9bbb6cc into Homebrew:master Oct 5, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 57035b3...8e82c2b
Details
codecov/project 67.15% (+<.01%) compared to 57035b3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 5, 2017

Member

Thanks for your first contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

Member

MikeMcQuaid commented Oct 5, 2017

Thanks for your first contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

@codylewis codylewis referenced this pull request Oct 6, 2017

Merged

Fixing link to CODE_OF_CONDUCT.md within README.md #3272

3 of 3 tasks complete

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.