New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: prefer assert/refute_predicate over File.exist? #3269

Merged
merged 1 commit into from Oct 6, 2017

Conversation

Projects
None yet
3 participants
@DomT4
Contributor

DomT4 commented Oct 5, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

assert_predicate and refute_predicate fail in a much clearer way than File.exist? does, and we've slowly started switching them over but @ilovezfs suggested audit was the way to go for consistency, so, here's a PR for him.

Before:

Error: minisign: failed
<false> is not true.

After:

Error: minisign: failed
<#<Pathname:/tmp/minisign-test-20171005-74992-3xoky/minisignb.pub>>.exist? is true value expected but was
<false>

@MikeMcQuaid MikeMcQuaid merged commit 3c0162a into Homebrew:master Oct 6, 2017

1 of 3 checks passed

codecov/patch 50% of diff hit (target 67.14%)
Details
codecov/project 67.12% (-0.02%) compared to 57035b3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 6, 2017

Member

Thanks again @DomT4!

Member

MikeMcQuaid commented Oct 6, 2017

Thanks again @DomT4!

richardcooper added a commit to richardcooper/homebrew-core that referenced this pull request Oct 6, 2017

pipenv 8.2.6: use assert_predicate not File.exist?
`brew audit` has a new requirement to prefer assert/refute_predicate over
File.exist? as of Homebrew/brew#3269

BrewTestBot added a commit to BrewTestBot/homebrew-core that referenced this pull request Oct 6, 2017

pipenv 8.2.6: use assert_predicate not File.exist?
`brew audit` has a new requirement to prefer assert/refute_predicate over
File.exist? as of Homebrew/brew#3269

@DomT4 DomT4 deleted the DomT4:assert_predicate branch Oct 6, 2017

@DomT4

This comment has been minimized.

Show comment
Hide comment
@DomT4

DomT4 Oct 6, 2017

Contributor

Thanks again @DomT4!

Thanks for merging ❤️.

OK I think I got all of them:

Nice! Thanks for that. It was on my radar at some point but I'm certainly not complaining 😉. Appreciated!

Contributor

DomT4 commented Oct 6, 2017

Thanks again @DomT4!

Thanks for merging ❤️.

OK I think I got all of them:

Nice! Thanks for that. It was on my radar at some point but I'm certainly not complaining 😉. Appreciated!

BrewTestBot added a commit to BrewTestBot/homebrew-core that referenced this pull request Oct 14, 2017

pipenv 8.2.6: use assert_predicate not File.exist?
`brew audit` has a new requirement to prefer assert/refute_predicate over
File.exist? as of Homebrew/brew#3269

BrewTestBot added a commit to BrewTestBot/homebrew-core that referenced this pull request Oct 21, 2017

pipenv 8.2.6: use assert_predicate not File.exist?
`brew audit` has a new requirement to prefer assert/refute_predicate over
File.exist? as of Homebrew/brew#3269

BrewTestBot added a commit to BrewTestBot/homebrew-core that referenced this pull request Oct 21, 2017

pipenv 8.2.6: use assert_predicate not File.exist?
`brew audit` has a new requirement to prefer assert/refute_predicate over
File.exist? as of Homebrew/brew#3269

BrewTestBot added a commit to BrewTestBot/homebrew-core that referenced this pull request Oct 23, 2017

pipenv 8.2.6: use assert_predicate not File.exist?
`brew audit` has a new requirement to prefer assert/refute_predicate over
File.exist? as of Homebrew/brew#3269

BrewTestBot added a commit to BrewTestBot/homebrew-core that referenced this pull request Oct 28, 2017

pipenv 8.2.6: use assert_predicate not File.exist?
`brew audit` has a new requirement to prefer assert/refute_predicate over
File.exist? as of Homebrew/brew#3269

BrewTestBot added a commit to BrewTestBot/homebrew-core that referenced this pull request Oct 28, 2017

pipenv 8.2.6: use assert_predicate not File.exist?
`brew audit` has a new requirement to prefer assert/refute_predicate over
File.exist? as of Homebrew/brew#3269

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.