New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add depends_on :linux and :macos #3270

Merged
merged 2 commits into from Oct 18, 2017

Conversation

Projects
None yet
3 participants
@sjackman
Contributor

sjackman commented Oct 5, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Allow a formula to declare whether it depends on macOS or Linux.

Show outdated Hide outdated Library/Homebrew/dependency_collector.rb Outdated
@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Oct 6, 2017

Contributor

How do you specify both that macOS is required and that a minimum version is required? My understanding is depends_on :macos => :el_capitan is a no-op on Linux.

Contributor

ilovezfs commented Oct 6, 2017

How do you specify both that macOS is required and that a minimum version is required? My understanding is depends_on :macos => :el_capitan is a no-op on Linux.

@sjackman

This comment has been minimized.

Show comment
Hide comment
@sjackman

sjackman Oct 6, 2017

Contributor

To specify that both that macOS is required and that a minimum version is required:

depends_on :macos
depends_on MinimumMacOSRequirement => :el_capitan
Contributor

sjackman commented Oct 6, 2017

To specify that both that macOS is required and that a minimum version is required:

depends_on :macos
depends_on MinimumMacOSRequirement => :el_capitan
@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Oct 6, 2017

Contributor

That seems like pretty yucky syntax to me.

Contributor

ilovezfs commented Oct 6, 2017

That seems like pretty yucky syntax to me.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 8, 2017

Member

Tests failing on Linux (shouldn't assume MacOS is specified there): https://travis-ci.org/Homebrew/brew/jobs/285144949

Member

MikeMcQuaid commented Oct 8, 2017

Tests failing on Linux (shouldn't assume MacOS is specified there): https://travis-ci.org/Homebrew/brew/jobs/285144949

@sjackman

This comment has been minimized.

Show comment
Hide comment
@sjackman

sjackman Oct 9, 2017

Contributor

Fixed up.

Contributor

sjackman commented Oct 9, 2017

Fixed up.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 9, 2017

Member

@sjackman Still got 🔴.

Member

MikeMcQuaid commented Oct 9, 2017

@sjackman Still got 🔴.

@sjackman

This comment has been minimized.

Show comment
Hide comment
@sjackman

sjackman Oct 10, 2017

Contributor

😬

Contributor

sjackman commented Oct 10, 2017

😬

@sjackman

This comment has been minimized.

Show comment
Hide comment
@sjackman

sjackman Oct 14, 2017

Contributor

Good to merge?

Contributor

sjackman commented Oct 14, 2017

Good to merge?

@sjackman sjackman referenced this pull request Oct 16, 2017

Closed

Cask: require macOS #3325

3 of 5 tasks complete

sjackman added some commits Feb 25, 2017

Rename MinimumMacOSRequirement to MacOSRequirement
Move MinimumMacOSRequirement to compat.

@MikeMcQuaid MikeMcQuaid merged commit c7d21da into Homebrew:master Oct 18, 2017

1 of 3 checks passed

codecov/patch 67.85% of diff hit (target 68.11%)
Details
codecov/project 67.09% (-1.03%) compared to cf34901
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 18, 2017

Member

Thanks @sjackman and sorry for the nit picking!

Member

MikeMcQuaid commented Oct 18, 2017

Thanks @sjackman and sorry for the nit picking!

@sjackman sjackman deleted the sjackman:os-requirement branch Oct 18, 2017

@sjackman

This comment has been minimized.

Show comment
Hide comment
@sjackman

sjackman Oct 18, 2017

Contributor

No worries. Thanks for merging, Mike.

Contributor

sjackman commented Oct 18, 2017

No worries. Thanks for merging, Mike.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.