New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cask AbstractArtifact: fix install order #3282

Merged
merged 2 commits into from Oct 7, 2017

Conversation

Projects
None yet
3 participants
@commitay
Member

commitay commented Oct 7, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Refs: #3267

Fixes binary running prior to pkg

https://travis-ci.org/caskroom/homebrew-cask/builds/284640024

/cc @reitermarkus

@reitermarkus

This comment has been minimized.

Show comment
Hide comment
@reitermarkus

reitermarkus Oct 7, 2017

Member

Can you add a comment explaining why it needs to be this way? So we don't forget in the future.

Member

reitermarkus commented Oct 7, 2017

Can you add a comment explaining why it needs to be this way? So we don't forget in the future.

@commitay

This comment has been minimized.

Show comment
Hide comment
@commitay

commitay Oct 7, 2017

Member

Done.

Member

commitay commented Oct 7, 2017

Done.

@reitermarkus reitermarkus merged commit ee6a2c4 into Homebrew:master Oct 7, 2017

2 of 3 checks passed

codecov/project 67.13% (-0.02%) compared to 8f43d6b
Details
codecov/patch Coverage not affected when comparing 8f43d6b...4fde8f5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@commitay commitay deleted the commitay:abstract-artifact branch Oct 7, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.