New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper method for Cask fixture paths and refactor CaskLoader. #3283

Merged
merged 1 commit into from Oct 7, 2017

Conversation

Projects
None yet
3 participants
@reitermarkus
Member

reitermarkus commented Oct 7, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

@reitermarkus reitermarkus requested a review from vitorgalvao Oct 7, 2017

@reitermarkus reitermarkus merged commit 5cbf8bd into Homebrew:master Oct 7, 2017

2 of 3 checks passed

codecov/patch 66.66% of diff hit (target 67.12%)
Details
codecov/project 67.15% (+0.02%) compared to 62315e9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reitermarkus reitermarkus deleted the reitermarkus:cask-loader branch Oct 7, 2017

@commitay

This comment has been minimized.

Show comment
Hide comment
@commitay

commitay Oct 8, 2017

Member

This seems to have broken _audit_modified_casks

https://travis-ci.org/caskroom/homebrew-cask/builds/284875811

>>> brew cask _audit_modified_casks a97b5b4c07939f93c7d3a92b5dd5102d16dbf1f7...3d6c8dd5f3acc7a4b3ee7674b77ae9711a170327
==> 1 modified cask: vfuse
audit for vfuse: failed
 - exception while auditing vfuse: bad URI(is not URI?): cask 'vfuse' do
Member

commitay commented Oct 8, 2017

This seems to have broken _audit_modified_casks

https://travis-ci.org/caskroom/homebrew-cask/builds/284875811

>>> brew cask _audit_modified_casks a97b5b4c07939f93c7d3a92b5dd5102d16dbf1f7...3d6c8dd5f3acc7a4b3ee7674b77ae9711a170327
==> 1 modified cask: vfuse
audit for vfuse: failed
 - exception while auditing vfuse: bad URI(is not URI?): cask 'vfuse' do

@reitermarkus reitermarkus referenced this pull request Oct 8, 2017

Merged

Fix regexes in `CaskLoader`. #3289

4 of 5 tasks complete

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.