New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RuboCop tests. #3284

Merged
merged 2 commits into from Oct 8, 2017

Conversation

Projects
None yet
4 participants
@reitermarkus
Member

reitermarkus commented Oct 7, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 7, 2017

Member

Can you explain how/why they are broken and need "fix"ed? Not disagreeing, just want to understand. CC @GauthamGoli too.

Member

MikeMcQuaid commented Oct 7, 2017

Can you explain how/why they are broken and need "fix"ed? Not disagreeing, just want to understand. CC @GauthamGoli too.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 7, 2017

Member

Can you explain how/why they are broken and need "fix"ed?

(ideally also in the commit message)

Member

MikeMcQuaid commented Oct 7, 2017

Can you explain how/why they are broken and need "fix"ed?

(ideally also in the commit message)

@reitermarkus

This comment has been minimized.

Show comment
Hide comment
@reitermarkus

reitermarkus Oct 7, 2017

Member

The tests are still running with RuboCop 0.49 because of the Gemfile.lock, and some methods have changed from 0.49 to 0.50.

Member

reitermarkus commented Oct 7, 2017

The tests are still running with RuboCop 0.49 because of the Gemfile.lock, and some methods have changed from 0.49 to 0.50.

gem "parallel_tests"
gem "rspec"
gem "rspec-its", require: false
gem "rspec-wait", require: false
gem "rubocop"
gem "rubocop", HOMEBREW_RUBOCOP_VERSION

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Oct 8, 2017

Member

👍

@MikeMcQuaid

MikeMcQuaid Oct 8, 2017

Member

👍

@GauthamGoli

This comment has been minimized.

Show comment
Hide comment
@GauthamGoli

GauthamGoli Oct 8, 2017

Member

Ah! This fixes RuboCop in Homebrew now. I have been looking at the wrong place.
Thanks @reitermarkus

Member

GauthamGoli commented Oct 8, 2017

Ah! This fixes RuboCop in Homebrew now. I have been looking at the wrong place.
Thanks @reitermarkus

@ilovezfs ilovezfs referenced this pull request Oct 8, 2017

Closed

description audit stopped working #3286

4 of 4 tasks complete
@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Oct 8, 2017

Contributor

It looks like this addresses #3286. I'd like to get this merged ASAP since we're currently without functioning brew audit.

Contributor

ilovezfs commented Oct 8, 2017

It looks like this addresses #3286. I'd like to get this merged ASAP since we're currently without functioning brew audit.

@ilovezfs ilovezfs merged commit 30ac040 into Homebrew:master Oct 8, 2017

3 checks passed

codecov/patch 100% of diff hit (target 67.14%)
Details
codecov/project 67.51% (+0.37%) compared to 5cbf8bd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Oct 8, 2017

Contributor

Merged. Hopefully nothing blows up but if it does, it's my fault not @reitermarkus's :)

Contributor

ilovezfs commented Oct 8, 2017

Merged. Hopefully nothing blows up but if it does, it's my fault not @reitermarkus's :)

@ilovezfs ilovezfs referenced this pull request Oct 8, 2017

Merged

Clean up code style and remove `.rubocop_todo.yml`. #3278

3 of 5 tasks complete

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.