New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: tweak assert/refute_predicate audit #3287

Merged
merged 1 commit into from Oct 8, 2017

Conversation

Projects
None yet
3 participants
@DomT4
Contributor

DomT4 commented Oct 8, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

Addresses some of the issues I raised in Homebrew/homebrew-core#19127 (comment).

Would still like to work out a way to check File.exist?-style language inside the test do block exclusively but for now it's better to be too conservative on the audit than to be overly-zealous and flag too much.

audit: tweak assert/refute_predicate audit
Addresses some of the issues I raised in Homebrew/homebrew-core#19127 (comment).
Would still like to work out a way to check `File.exist?`-style language
inside the `test do` block exclusively but for now it's better to be
too conservative on the audit than to be overly-zealous and flag too
much.

@DomT4 DomT4 referenced this pull request Oct 8, 2017

Merged

.exist => assert_predicate #19127

3 of 3 tasks complete

@ilovezfs ilovezfs merged commit b568179 into Homebrew:master Oct 8, 2017

1 of 3 checks passed

codecov/patch 66.66% of diff hit (target 67.75%)
Details
codecov/project 67.05% (-0.71%) compared to 30ac040
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Oct 8, 2017

Contributor

Thanks, Mr. T!

Contributor

ilovezfs commented Oct 8, 2017

Thanks, Mr. T!

@DomT4 DomT4 deleted the DomT4:assert_predicate_audit branch Oct 8, 2017

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 8, 2017

Member

@DomT4 It's worth perhaps chatting with @GauthamGoli some time about getting this into a RuboCop test which would be able to do things such as scope it to test do only and ignore weird use of whitespace.

Member

MikeMcQuaid commented Oct 8, 2017

@DomT4 It's worth perhaps chatting with @GauthamGoli some time about getting this into a RuboCop test which would be able to do things such as scope it to test do only and ignore weird use of whitespace.

@DomT4

This comment has been minimized.

Show comment
Hide comment
@DomT4

DomT4 Oct 8, 2017

Contributor

@MikeMcQuaid Aye, probably. I tend to find Rubocop's syntax pretty grim to work with, but Rubocop seems to be the direction Homebrew is moving in so I guess I'll need to wrap my head around it more contently at some point.

Contributor

DomT4 commented Oct 8, 2017

@MikeMcQuaid Aye, probably. I tend to find Rubocop's syntax pretty grim to work with, but Rubocop seems to be the direction Homebrew is moving in so I guess I'll need to wrap my head around it more contently at some point.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.