New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regexes in `CaskLoader`. #3289

merged 2 commits into from Oct 8, 2017


None yet
1 participant

reitermarkus commented Oct 8, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Fixes #3283 (comment).

reitermarkus added some commits Oct 8, 2017

@reitermarkus reitermarkus merged commit 91ab116 into Homebrew:master Oct 8, 2017

3 checks passed

codecov/patch 100% of diff hit (target 67.72%)
codecov/project Absolute coverage decreased by -0.49% but relative coverage increased by +32.27% compared to b568179
continuous-integration/travis-ci/pr The Travis CI build passed

@reitermarkus reitermarkus deleted the reitermarkus:cask-loader branch Oct 8, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.