New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lines_cop: add ENV.universal_binary audit exemption for wine #3291

Merged
merged 3 commits into from Oct 18, 2017

Conversation

Projects
None yet
4 participants
@JCount
Member

JCount commented Oct 9, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

add ENV.universal_binary audit exception for wine and corresponding test coverage

@JCount

This comment has been minimized.

Show comment
Hide comment
@JCount
Member

JCount commented Oct 9, 2017

@JCount

This comment has been minimized.

Show comment
Hide comment
@JCount

JCount Oct 9, 2017

Member

@reitermarkus Is something like this what you had in mind?

Member

JCount commented Oct 9, 2017

@reitermarkus Is something like this what you had in mind?

@JCount

This comment has been minimized.

Show comment
Hide comment
@JCount

JCount Oct 13, 2017

Member

@reitermarkus gentle ping on this

Member

JCount commented Oct 13, 2017

@reitermarkus gentle ping on this

@reitermarkus

This comment has been minimized.

Show comment
Hide comment
@reitermarkus

reitermarkus Oct 13, 2017

Member

Something like this is what I had in mind.

Member

reitermarkus commented Oct 13, 2017

Something like this is what I had in mind.

@JCount

This comment has been minimized.

Show comment
Hide comment
@JCount

JCount Oct 13, 2017

Member

Since this has the context When auditing formulae prepended to both tests, making the wording following the it into complete sentences, would, in my mind, only serve to make things less intelligible.

Member

JCount commented Oct 13, 2017

Since this has the context When auditing formulae prepended to both tests, making the wording following the it into complete sentences, would, in my mind, only serve to make things less intelligible.

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Oct 14, 2017

Contributor

it "is as quiet as a church mouse when there is an exemption from the deprecation of ENV.universal_binary" do

Contributor

ilovezfs commented Oct 14, 2017

it "is as quiet as a church mouse when there is an exemption from the deprecation of ENV.universal_binary" do

@reitermarkus

This comment has been minimized.

Show comment
Hide comment
@reitermarkus

reitermarkus Oct 15, 2017

Member

… in my mind, only serve to make things less intelligible.

It should be possible to make it more intelligible than “when auditing formulae it with a build.universal? exemption”.

Also, the context is pretty redundant, so this could actually be removed, and we'd just have it "does not report build.universal? offenses for Wine" do, which would be pretty clear to me.

Member

reitermarkus commented Oct 15, 2017

… in my mind, only serve to make things less intelligible.

It should be possible to make it more intelligible than “when auditing formulae it with a build.universal? exemption”.

Also, the context is pretty redundant, so this could actually be removed, and we'd just have it "does not report build.universal? offenses for Wine" do, which would be pretty clear to me.

@JCount JCount changed the title from lines_cop: add ENV.universal_binary audit exception for wine to lines_cop: add ENV.universal_binary audit exemption for wine Oct 15, 2017

@MikeMcQuaid

Thanks @JCount!

@MikeMcQuaid MikeMcQuaid merged commit 1d40061 into Homebrew:master Oct 18, 2017

3 checks passed

codecov/patch 100% of diff hit (target 66.63%)
Details
codecov/project 67.63% (+0.99%) compared to e1808bf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@JCount JCount deleted the JCount:lines-cop-fix-wine-universal-binary branch Oct 18, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.