New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: more *_predicate nudging/tweaks #3293

Merged
merged 2 commits into from Oct 17, 2017

Conversation

Projects
None yet
3 participants
@DomT4
Contributor

DomT4 commented Oct 9, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

CC @ilovezfs.

Homebrew/homebrew-core#19213 (comment)

Show outdated Hide outdated Library/Homebrew/dev-cmd/audit.rb Outdated

@DomT4 DomT4 referenced this pull request Oct 14, 2017

Merged

audit: Port line_problems to rubocop and add tests part 4 #3313

5 of 5 tasks complete
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 17, 2017

Member

Given #3313 I think this should probably be integrated in there instead.

Member

MikeMcQuaid commented Oct 17, 2017

Given #3313 I think this should probably be integrated in there instead.

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Oct 17, 2017

Contributor

Given it seems to be working fine I'm not sure why it needs to be made fancier and block on that happening.

Contributor

ilovezfs commented Oct 17, 2017

Given it seems to be working fine I'm not sure why it needs to be made fancier and block on that happening.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 17, 2017

Member

Ok then. Once #3313 goes in, though, future changes will need to be to the Rubocop.

Member

MikeMcQuaid commented Oct 17, 2017

Ok then. Once #3313 goes in, though, future changes will need to be to the Rubocop.

@MikeMcQuaid MikeMcQuaid merged commit 77f3fcf into Homebrew:master Oct 17, 2017

1 of 3 checks passed

codecov/patch 40% of diff hit (target 68.11%)
Details
codecov/project 67.4% (-0.71%) compared to 56458f0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@DomT4 DomT4 deleted the DomT4:predicate_audit branch Oct 17, 2017

@DomT4

This comment has been minimized.

Show comment
Hide comment
@DomT4

DomT4 Oct 17, 2017

Contributor

Thanks for merging! I was happy either way. At some point I'm going to have to sit down & wrap my head around the Rubocop format for everything, but I'll take being able to put that off for a little longer 🙈.

Contributor

DomT4 commented Oct 17, 2017

Thanks for merging! I was happy either way. At some point I'm going to have to sit down & wrap my head around the Rubocop format for everything, but I'll take being able to put that off for a little longer 🙈.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.