New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readall: allow readall-ing multiple taps at once #3302

Merged
merged 2 commits into from Oct 20, 2017

Conversation

Projects
None yet
3 participants
@maxim-belkin
Contributor

maxim-belkin commented Oct 10, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Current behavior:

$ brew readall homebrew/core homebrew/dev-tools

processes homebrew/core only

This PR "improves" readall's behavior so that all specified taps are processed

@@ -31,7 +31,7 @@ def readall
taps = if ARGV.named.empty?
Tap
else
[Tap.fetch(ARGV.named.first)]
ARGV.named.map { |t| Tap.fetch(t) }

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Oct 18, 2017

Member

The help at the top needs updated to match the fact it can take multiple taps. Otherwise 👍

@MikeMcQuaid

MikeMcQuaid Oct 18, 2017

Member

The help at the top needs updated to match the fact it can take multiple taps. Otherwise 👍

@MikeMcQuaid MikeMcQuaid merged commit 460048b into Homebrew:master Oct 20, 2017

3 checks passed

codecov/patch 100% of diff hit (target 66.9%)
Details
codecov/project 67.71% (+0.8%) compared to 56458f0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 20, 2017

Member

Thanks again @maxim-belkin!

Member

MikeMcQuaid commented Oct 20, 2017

Thanks again @maxim-belkin!

@maxim-belkin maxim-belkin deleted the maxim-belkin:readall-multiple-taps branch Oct 20, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.