New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileutils: deprecate rake DSL #3312

Merged
merged 1 commit into from Oct 13, 2017

Conversation

Projects
None yet
2 participants
@ilovezfs
Contributor

ilovezfs commented Oct 13, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

superenv and the :ruby requirement make a rake DSL unnecessary.

Fixes #3310.

@ilovezfs ilovezfs requested a review from MikeMcQuaid Oct 13, 2017

@MikeMcQuaid

Needs an addition to Library/Homebrew/compat/formula.rb or Library/Homebrew/compat/fileutils.rb with system "rake", *args but when that's the case: 👍

fileutils: deprecate rake DSL
superenv and the `:ruby` requirement make a `rake` DSL unnecessary.

@ilovezfs ilovezfs changed the title from fileutils: remove rake DSL to fileutils: deprecate rake DSL Oct 13, 2017

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid
Member

MikeMcQuaid commented Oct 13, 2017

:shipit:

@ilovezfs ilovezfs removed the do not merge label Oct 13, 2017

@ilovezfs ilovezfs merged commit 64270ed into Homebrew:master Oct 13, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 30b84ac...82afe5d
Details
codecov/project 67.25% (+0.11%) compared to 30b84ac
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.