New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: Port line_problems to rubocop and add tests part 4 #3313

Merged
merged 39 commits into from Oct 24, 2017

Conversation

Projects
None yet
5 participants
@GauthamGoli
Member

GauthamGoli commented Oct 13, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

#569

This almost completely ports line_problems . This is a huge change, and I wrote tests for every rule that has been ported. Feel free to suggest additional tests and I would add them.
Opening a PR so it can be reviewed as there are no conflicts now.

GauthamGoli added some commits Jul 30, 2017

Show outdated Hide outdated Library/.rubocop.yml Outdated
@DomT4

This comment has been minimized.

Show comment
Hide comment
@DomT4

DomT4 Oct 14, 2017

Contributor

Small note: This PR semi-bumps into #3293. I can always tweak that PR afterwards if this goes in first though, not a huge issue.

Contributor

DomT4 commented Oct 14, 2017

Small note: This PR semi-bumps into #3293. I can always tweak that PR afterwards if this goes in first though, not a huge issue.

@MikeMcQuaid MikeMcQuaid referenced this pull request Oct 17, 2017

Merged

audit: more *_predicate nudging/tweaks #3293

3 of 3 tasks complete
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 17, 2017

Member

@GauthamGoli Needs rebased now #3293 was merged, sorry. Also, some brew style failures here. Let us know when comments/style/tests are addressed and I'll try and do some tests and get this merged soon after.

Member

MikeMcQuaid commented Oct 17, 2017

@GauthamGoli Needs rebased now #3293 was merged, sorry. Also, some brew style failures here. Let us know when comments/style/tests are addressed and I'll try and do some tests and get this merged soon after.

@GauthamGoli GauthamGoli changed the title from audit: Port line_problems to rubocop and add tests part 4 to [WIP] audit: Port line_problems to rubocop and add tests part 4 Oct 18, 2017

@GauthamGoli GauthamGoli changed the title from [WIP] audit: Port line_problems to rubocop and add tests part 4 to audit: Port line_problems to rubocop and add tests part 4 Oct 21, 2017

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 24, 2017

Member

Nice work here @GauthamGoli, thanks again!

Member

MikeMcQuaid commented Oct 24, 2017

Nice work here @GauthamGoli, thanks again!

@MikeMcQuaid MikeMcQuaid merged commit 7f46dcf into Homebrew:master Oct 24, 2017

3 checks passed

codecov/patch 99.39% of diff hit (target 68.28%)
Details
codecov/project 68.35% (+0.06%) compared to a08f1c6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Oct 24, 2017

Contributor

This is causing

Error: 1 problem in 1 formula
infer:
  * C: 54: col 85: Use "#{ENV.cc}" instead of hard-coding "clang"

on Homebrew/homebrew-core#19646

See https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/11525/version=high_sierra/testReport/junit/brew-test-bot/high_sierra/audit_infer___online/

Contributor

ilovezfs commented Oct 24, 2017

This is causing

Error: 1 problem in 1 formula
infer:
  * C: 54: col 85: Use "#{ENV.cc}" instead of hard-coding "clang"

on Homebrew/homebrew-core#19646

See https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/11525/version=high_sierra/testReport/junit/brew-test-bot/high_sierra/audit_infer___online/

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.