New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editing invalid Casks. #3323

Merged
merged 1 commit into from Oct 17, 2017

Conversation

Projects
None yet
2 participants
@reitermarkus
Member

reitermarkus commented Oct 15, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Invalid Casks should be fixable with brew cask edit.

@reitermarkus reitermarkus requested a review from vitorgalvao Oct 15, 2017

@reitermarkus reitermarkus merged commit cf34901 into Homebrew:master Oct 17, 2017

1 of 3 checks passed

codecov/patch 40% of diff hit (target 68.28%)
Details
codecov/project 67.55% (-0.73%) compared to b4e1e39
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reitermarkus reitermarkus deleted the reitermarkus:edit-invalid-cask branch Oct 17, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.