New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portable-ruby: use rebuild with coverage support for Linux. #3326

Merged
merged 1 commit into from Oct 18, 2017

Conversation

Projects
None yet
2 participants
@sjackman
Contributor

sjackman commented Oct 16, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

This will allow simplecov to generate coverage by rebuilding portable Ruby with coverage support.

portable-ruby: use rebuild with coverage support for Linux.
This will allow `simplecov` to generate coverage by rebuilding portable
Ruby with coverage support.
@sjackman

This comment has been minimized.

Show comment
Hide comment
@sjackman

sjackman Oct 16, 2017

Contributor

I've sent the updated bottle to @MikeMcQuaid. It must be uploaded to Bintray before merging this PR.

Contributor

sjackman commented Oct 16, 2017

I've sent the updated bottle to @MikeMcQuaid. It must be uploaded to Bintray before merging this PR.

@sjackman sjackman changed the title from portable-ruby: use rebuild with coverage support for Linux. to [DO NOT MERGE] portable-ruby: use rebuild with coverage support for Linux. Oct 16, 2017

@MikeMcQuaid MikeMcQuaid changed the title from [DO NOT MERGE] portable-ruby: use rebuild with coverage support for Linux. to portable-ruby: use rebuild with coverage support for Linux. Oct 18, 2017

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid
Member

MikeMcQuaid commented Oct 18, 2017

Thanks @sjackman!

@MikeMcQuaid MikeMcQuaid merged commit 270b752 into Homebrew:master Oct 18, 2017

2 of 3 checks passed

codecov/project 67.58% (-0.71%) compared to b4e1e39
Details
codecov/patch Coverage not affected when comparing b4e1e39...90ca552
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sjackman sjackman deleted the sjackman:portable-ruby branch Oct 18, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.