New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifies which errant version of Ruby is used in raise. #3329

Merged
merged 1 commit into from Oct 18, 2017

Conversation

Projects
None yet
3 participants
@ashfurrow
Contributor

ashfurrow commented Oct 17, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

As discussed here, it would be helpful to display which version of Ruby is actually being used in the error message when used in non-2.3 environments. This is especially useful when running commands remotely, such as on CI.

Regarding testing: I didn't see any existing tests (I don't think it'd be easy to test this, as the code is executed at the top level) but if you point me in the right direction I'm sure I could figure it out.

Show outdated Hide outdated Library/Homebrew/brew.rb Outdated

@reitermarkus reitermarkus merged commit c4e8c79 into Homebrew:master Oct 18, 2017

2 of 3 checks passed

codecov/project 67.16% (-0.96%) compared to cf34901
Details
codecov/patch Coverage not affected when comparing cf34901...11572c7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reitermarkus

This comment has been minimized.

Show comment
Hide comment
@reitermarkus
Member

reitermarkus commented Oct 18, 2017

Thanks, @ashfurrow!

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 18, 2017

Member

As discussed here, it would be helpful to display which version of Ruby is actually being used in the error message when used in non-2.3 environments. This is especially useful when running commands remotely, such as on CI.

@ashfurrow For what it's worth: any time you see this message unless you've manually set HOMEBREW_RUBY_PATH we consider it a bug. Can you elaborate on where you've seen this?

Member

MikeMcQuaid commented Oct 18, 2017

As discussed here, it would be helpful to display which version of Ruby is actually being used in the error message when used in non-2.3 environments. This is especially useful when running commands remotely, such as on CI.

@ashfurrow For what it's worth: any time you see this message unless you've manually set HOMEBREW_RUBY_PATH we consider it a bug. Can you elaborate on where you've seen this?

@ashfurrow ashfurrow deleted the ashfurrow:messaging branch Oct 18, 2017

@ashfurrow

This comment has been minimized.

Show comment
Hide comment
@ashfurrow

ashfurrow Oct 18, 2017

Contributor

Interesting! The issue came up on our CI provider, fixed by this PR. I was pointed in the direction of running brew update on this thread. Let me know if there's any more info I can provide.

Contributor

ashfurrow commented Oct 18, 2017

Interesting! The issue came up on our CI provider, fixed by this PR. I was pointed in the direction of running brew update on this thread. Let me know if there's any more info I can provide.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 20, 2017

Member

Ok, I think that's the same as a bug we've seen before. I'll look at addressing it, thanks.

Member

MikeMcQuaid commented Oct 20, 2017

Ok, I think that's the same as a bug we've seen before. I'll look at addressing it, thanks.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Nov 3, 2017

Member

I'm afraid I've tried but cannot reproduce this on even updates from very old Homebrews now so I can only presume I've fixed it.

Member

MikeMcQuaid commented Nov 3, 2017

I'm afraid I've tried but cannot reproduce this on even updates from very old Homebrews now so I can only presume I've fixed it.

@ashfurrow

This comment has been minimized.

Show comment
Hide comment
@ashfurrow

ashfurrow Nov 3, 2017

Contributor

Thank you for following up 🌟

Contributor

ashfurrow commented Nov 3, 2017

Thank you for following up 🌟

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.