New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java_requirement: fix Java 9 version detection #3333

Merged
merged 1 commit into from Oct 18, 2017

Conversation

Projects
None yet
4 participants
@DomT4
Contributor

DomT4 commented Oct 18, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run brew tests with your changes locally?

I went for pretty much the most obvious possible fix here, so feel free to debate/request changes/etc as desired. We don't really need to consider post-period digit with Java 9 onwards, but retaining the existing behaviour there shouldn't cause issues with existing Java dependencies in core (as far as I can see) because 9 > 1.

Obviously the /(1|9)\.\d/ won't support Java 10 but that problem is likely several years away.

Closes #3331.

@commitay

This comment has been minimized.

Show comment
Hide comment
@commitay

commitay Oct 18, 2017

Member

Thanks for taking care of this @DomT4! I forgot about the java_requirement for Formula.


Obviously the /(1|9)\.\d/ won't support Java 10 but that problem is likely several years away.

Java 18.3 is scheduled for release March 2018

http://www.oracle.com/technetwork/java/javase/eol-135779.html

Member

commitay commented Oct 18, 2017

Thanks for taking care of this @DomT4! I forgot about the java_requirement for Formula.


Obviously the /(1|9)\.\d/ won't support Java 10 but that problem is likely several years away.

Java 18.3 is scheduled for release March 2018

http://www.oracle.com/technetwork/java/javase/eol-135779.html

@commitay commitay referenced this pull request Oct 18, 2017

Merged

java 9.0.1,11 #39751

3 of 3 tasks complete
@DomT4

This comment has been minimized.

Show comment
Hide comment
@DomT4

DomT4 Oct 18, 2017

Contributor

Java 18.3 is scheduled for release March 2018

What the heck are ya doing with your version schemes Oracle 😅. Thanks for letting me know about that, I guess we shouldn't punt the problem then.

Contributor

DomT4 commented Oct 18, 2017

Java 18.3 is scheduled for release March 2018

What the heck are ya doing with your version schemes Oracle 😅. Thanks for letting me know about that, I guess we shouldn't punt the problem then.

@MikeMcQuaid MikeMcQuaid merged commit a5c8628 into Homebrew:master Oct 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 18, 2017

Member

Thanks again @DomT4!

Member

MikeMcQuaid commented Oct 18, 2017

Thanks again @DomT4!

@DomT4 DomT4 deleted the DomT4:java_versioning branch Oct 18, 2017

@DomT4

This comment has been minimized.

Show comment
Hide comment
@DomT4

DomT4 Oct 18, 2017

Contributor

Thanks for the input all ❤️.

Contributor

DomT4 commented Oct 18, 2017

Thanks for the input all ❤️.

@iMichka iMichka referenced this pull request Oct 18, 2017

Closed

jdk9: update to jdk 9.0.1+11 #4719

3 of 4 tasks complete

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.