Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcode: update to Xcode 9.0.1 on 10.12 and 10.13 #3335

Merged
merged 1 commit into from Oct 20, 2017

Conversation

JCount
Copy link
Contributor

@JCount JCount commented Oct 18, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Xcode 9.0.1 and the 9.0.1 CLT are out for both 10.12 and 10.13.

@DomT4
Copy link
Member

DomT4 commented Oct 18, 2017

Thanks for catching this. Was on my to-do list, along with a bunch of other stuff 😅.

@JCount
Copy link
Contributor Author

JCount commented Oct 19, 2017

😆

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 when our CI boxes are updated accordingly. "Fun" suggested task for another time: add a CI check to ensure docs/Xcode.md is always kept up to date (and maybe even a command to automatically spit out the output based on os/mac and os/mac/xcode

@MikeMcQuaid MikeMcQuaid merged commit 6fe7c5f into Homebrew:master Oct 20, 2017
@MikeMcQuaid
Copy link
Member

Thanks @JCount!

@JCount JCount deleted the xcode-9.0.1 branch October 20, 2017 17:30
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants