New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leaves: account for requirements #3345

Merged
merged 1 commit into from Oct 24, 2017

Conversation

Projects
None yet
2 participants
@maxim-belkin
Contributor

maxim-belkin commented Oct 20, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

See #3344 (comment)

After:

$ brew leaves 
atk
fdupes
gdk-pixbuf
gnu-sed
hicolor-icon-theme
jpegoptim
p7zip
pango
pstree
pyenv
r
rbenv
tree
vim

Fixes #3100
Closes #3344

@maxim-belkin

This comment has been minimized.

Show comment
Hide comment
@maxim-belkin

maxim-belkin Oct 20, 2017

Contributor

I don't think this is what was requested but it works 🙄

Contributor

maxim-belkin commented Oct 20, 2017

I don't think this is what was requested but it works 🙄

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 20, 2017

Member

I don't think this is what was requested but it works 🙄

Sorry I don't really understand this comment (and don't appreciate the 🙄).

Member

MikeMcQuaid commented Oct 20, 2017

I don't think this is what was requested but it works 🙄

Sorry I don't really understand this comment (and don't appreciate the 🙄).

@maxim-belkin

This comment has been minimized.

Show comment
Hide comment
@maxim-belkin

maxim-belkin Oct 20, 2017

Contributor

this pr uses f.runtime_dependency, where f == formula, not tab of keg as you suggested in #3344 (comment)

and don't appreciate the 🙄)

ok :)

Contributor

maxim-belkin commented Oct 20, 2017

this pr uses f.runtime_dependency, where f == formula, not tab of keg as you suggested in #3344 (comment)

and don't appreciate the 🙄)

ok :)

@maxim-belkin maxim-belkin referenced this pull request Oct 23, 2017

Closed

leaves: account for requirements #3344

3 of 5 tasks complete

@MikeMcQuaid MikeMcQuaid merged commit 78b0127 into Homebrew:master Oct 24, 2017

3 checks passed

codecov/patch 100% of diff hit (target 68.08%)
Details
codecov/project 68.22% (+0.14%) compared to 6fe7c5f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 24, 2017

Member

🎉 Great work here again @maxim-belkin and apologies for my earlier grumpiness.

Member

MikeMcQuaid commented Oct 24, 2017

🎉 Great work here again @maxim-belkin and apologies for my earlier grumpiness.

@maxim-belkin maxim-belkin deleted the maxim-belkin:coffee-leaves branch Oct 24, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.