New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagnostic: handle APFS returning hash order #3347

Merged
merged 1 commit into from Oct 21, 2017

Conversation

Projects
None yet
2 participants
@DomT4
Contributor

DomT4 commented Oct 20, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run brew tests with your changes locally?

Apart from the TODO in tap-info I think this is the final known case of #3311.

@DomT4 DomT4 referenced this pull request Oct 20, 2017

Merged

Handle APFS returning hash order. #3316

4 of 4 tasks complete
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 21, 2017

Member

Thanks again @DomT4!

Member

MikeMcQuaid commented Oct 21, 2017

Thanks again @DomT4!

@MikeMcQuaid MikeMcQuaid merged commit ce0e96c into Homebrew:master Oct 21, 2017

1 of 3 checks passed

codecov/patch 0% of diff hit (target 68.08%)
Details
codecov/project 67.55% (-0.54%) compared to 6fe7c5f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@DomT4 DomT4 deleted the DomT4:apfs_diagnostic branch Oct 21, 2017

@DomT4

This comment has been minimized.

Show comment
Hide comment
@DomT4

DomT4 Oct 21, 2017

Contributor

Thanks Mike ❤️

Contributor

DomT4 commented Oct 21, 2017

Thanks Mike ❤️

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.