Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Rubocop 0.51 #3349
Update RuboCop to 0.51 and fix/refactor specs.
This was referenced
Oct 23, 2017
@reitermarkus I notice that you've changed several structured expectations like
into exact string matches that involve things like
Is this a mandatory change dictated by 0.51 or something you're electing to do, that we could choose not to do? I think we're going backwards in terms of maintainability and readability moving from the former to the latter, even if it is fewer lines.
I'm in favour of using RuboCop's version rather than ours here even if this means a slightly less structured approach.