New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpg: a little intentional yak shaving #3350

Merged
merged 2 commits into from Oct 22, 2017

Conversation

Projects
None yet
2 participants
@DomT4
Contributor

DomT4 commented Oct 22, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run brew tests with your changes locally?

DomT4 added some commits Oct 22, 2017

gpg: make executable a function, not a constant
It's a lot nicer to call `Gpg.executable` rather than
`Gpg::GPG_EXECUTABLE` externally. Also squash some logic.
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 22, 2017

Member

Thanks again @DomT4!

Member

MikeMcQuaid commented Oct 22, 2017

Thanks again @DomT4!

@MikeMcQuaid MikeMcQuaid merged commit 357b7bb into Homebrew:master Oct 22, 2017

1 of 3 checks passed

codecov/patch 66.66% of diff hit (target 68.22%)
Details
codecov/project 68.12% (-0.11%) compared to ce0e96c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@DomT4 DomT4 deleted the DomT4:gpg_executable branch Oct 22, 2017

@DomT4

This comment has been minimized.

Show comment
Hide comment
@DomT4

DomT4 Oct 22, 2017

Contributor

Thanks Mike!

Contributor

DomT4 commented Oct 22, 2017

Thanks Mike!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.