New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix poor visibility in syntax highlighting #3356

Merged
merged 1 commit into from Oct 26, 2017

Conversation

Projects
None yet
3 participants
@jonchang
Member

jonchang commented Oct 23, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Some syntax highlighting on docs.brew.sh are illegible due to low contrast.

Before:

image

After:

image

@scpeters

This comment has been minimized.

Show comment
Hide comment
@scpeters

scpeters Oct 23, 2017

Contributor

Example is from this page:

I agree that it's hard to read

Contributor

scpeters commented Oct 23, 2017

Example is from this page:

I agree that it's hard to read

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid
Member

MikeMcQuaid commented Oct 24, 2017

@jonchang

This comment has been minimized.

Show comment
Hide comment
@jonchang
Member

jonchang commented Oct 25, 2017

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid
Member

MikeMcQuaid commented Oct 26, 2017

Thanks @jonchang!

@MikeMcQuaid MikeMcQuaid merged commit 4d02b96 into Homebrew:master Oct 26, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 357b7bb...6554b25
Details
codecov/project 67.5% (+0.43%) compared to 357b7bb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.