New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lines_cop: Fix detection of negated expression #3366

Merged
merged 1 commit into from Oct 26, 2017

Conversation

Projects
None yet
2 participants
@GauthamGoli
Member

GauthamGoli commented Oct 25, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • [] Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

In chained conditional statements if any one condition is negated, false positives were being raised.
Example: build.with?("libcxx") || !MacOS::CLT.installed? in llvm formula

@MikeMcQuaid MikeMcQuaid merged commit 40b2123 into Homebrew:master Oct 26, 2017

3 checks passed

codecov/patch 100% of diff hit (target 68.51%)
Details
codecov/project Absolute coverage decreased by -0.31% but relative coverage increased by +31.48% compared to 4d02b96
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 26, 2017

Member

Thanks again @GauthamGoli!

Member

MikeMcQuaid commented Oct 26, 2017

Thanks again @GauthamGoli!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.