New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tap-info: handle APFS returning hash order #3380

Merged
merged 2 commits into from Oct 28, 2017

Conversation

Projects
None yet
3 participants
@jmsundar
Contributor

jmsundar commented Oct 27, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run brew tests with your changes locally?

Fixes #3311.

Show outdated Hide outdated Library/Homebrew/cmd/tap-info.rb Outdated

@MikeMcQuaid MikeMcQuaid merged commit 7caca57 into Homebrew:master Oct 28, 2017

3 checks passed

codecov/patch 100% of diff hit (target 67.59%)
Details
codecov/project 67.94% (+0.35%) compared to badbb00
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 28, 2017

Member

Thanks for your first contribution to Homebrew, @jmsundar! Without people like you submitting PRs we couldn't run this project. You rock!

Member

MikeMcQuaid commented Oct 28, 2017

Thanks for your first contribution to Homebrew, @jmsundar! Without people like you submitting PRs we couldn't run this project. You rock!

@DomT4

This comment has been minimized.

Show comment
Hide comment
@DomT4

DomT4 Oct 28, 2017

Contributor

Thanks for grabbing this last one @jmsundar. Life has not been consistently kind to my schedule lately 😓.

Contributor

DomT4 commented Oct 28, 2017

Thanks for grabbing this last one @jmsundar. Life has not been consistently kind to my schedule lately 😓.

@jmsundar jmsundar deleted the jmsundar:apfs_tap-info branch Nov 2, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.