New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tap-info: handle APFS returning hash order #3380

Merged
merged 2 commits into from Oct 28, 2017
Jump to file or symbol
Failed to load files and symbols.
+2 −3
Diff settings

Always

Just for now

Next

tap-info: sort taps by name to handle APFS

  • Loading branch information...
jmsundar committed Oct 27, 2017
commit 590f06187f252bc7e03874bc51bfeb1ebcd5a139
@@ -21,7 +21,6 @@ module Homebrew
module_function
def tap_info
# TODO: This still returns a non-alphabetised list on APFS.
if ARGV.include? "--installed"
taps = Tap
else
@@ -31,9 +30,9 @@ def tap_info
end
if ARGV.json == "v1"
print_tap_json(taps)
print_tap_json(taps.sort_by {|tap| tap.to_s})

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Oct 27, 2017

Member

Run brew style and it'll point out a couple of style tweaks for this line (and the change below, too).

This comment has been minimized.

@jmsundar

jmsundar Oct 28, 2017

Contributor

Ah I see, thanks. Tweaked.

else
print_tap_info(taps)
print_tap_info(taps.sort_by {|tap| tap.to_s})
end
end
ProTip! Use n and p to navigate between commits in a pull request.