New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lock.sh: suppress error output when looking for flock #3381

Merged
merged 1 commit into from Oct 27, 2017

Conversation

Projects
None yet
2 participants
@iMichka
Contributor

iMichka commented Oct 27, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Fixes (on centos6):

which: no flock in (/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin)

The checks for ruby and python at the same location have already their error message suppressed, so I think it makes sense to suppress that one too.

cc @sjackman

lock.sh: suppress error output when looking for flock
Fixes (on centos6):
which: no flock in (/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin)

@MikeMcQuaid MikeMcQuaid merged commit b2e2e4b into Homebrew:master Oct 27, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 2be11f6...b93ed41
Details
codecov/project 68.55% (+0.47%) compared to 2be11f6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 27, 2017

Member

Makes sense, thanks again @iMichka!

Member

MikeMcQuaid commented Oct 27, 2017

Makes sense, thanks again @iMichka!

@iMichka iMichka deleted the iMichka:flock branch Oct 27, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.