New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lines_cop: add missing e.g. clang++ regex SOL. #3382

Merged
merged 1 commit into from Oct 27, 2017

Conversation

Projects
None yet
3 participants
@MikeMcQuaid
Member

MikeMcQuaid commented Oct 27, 2017

You need a start of line check in this regex (like was added in the others) to allow things like #{bin}/clang++.

CC @ilovezfs @GauthamGoli

lines_cop: add missing e.g. clang++ regex SOL.
You need a start of line check in this regex (like was added in the
others) to allow things like `#{bin}/clang++`.

@MikeMcQuaid MikeMcQuaid merged commit 4209275 into Homebrew:master Oct 27, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:lines_cop_clang++ branch Oct 27, 2017

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Oct 28, 2017

Contributor

@MikeMcQuaid @GauthamGoli There are more of these.

pipenv:
  * C: 124: col 17: Use ENV instead of invoking 'env' to modify the environment

triggered by system "#{bin}/pipenv", "install", "requests"

Contributor

ilovezfs commented Oct 28, 2017

@MikeMcQuaid @GauthamGoli There are more of these.

pipenv:
  * C: 124: col 17: Use ENV instead of invoking 'env' to modify the environment

triggered by system "#{bin}/pipenv", "install", "requests"

@ilovezfs ilovezfs referenced this pull request Oct 28, 2017

Closed

pipenv 8.3.0 (new formula) #19060

4 of 4 tasks complete
@GauthamGoli

This comment has been minimized.

Show comment
Hide comment
@GauthamGoli

GauthamGoli Oct 28, 2017

Member

Thanks. Will fix them by tomorrow.

Member

GauthamGoli commented Oct 28, 2017

Thanks. Will fix them by tomorrow.

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Oct 28, 2017

Contributor

Thanks @GauthamGoli :)

Contributor

ilovezfs commented Oct 28, 2017

Thanks @GauthamGoli :)

@richardcooper richardcooper referenced this pull request Oct 30, 2017

Closed

Pipenv 8.3.1 #20053

3 of 4 tasks complete

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.