New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and cleanup some PATH usage. #3385

Merged
merged 4 commits into from Nov 3, 2017

Conversation

Projects
None yet
1 participant
@MikeMcQuaid
Member

MikeMcQuaid commented Oct 28, 2017

  • brew.rb: cleanup PATH setup. Avoid adding all the tap commands to the PATH when not necessary.
  • requirement: convert Cellar path to opt path.
  • requirement: prepend rather than append PATH. Otherwise this ends up behind e.g. /usr/bin so is pretty useless. Fixes #2875.

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:path-fixes-cleanup branch Nov 2, 2017

@MikeMcQuaid MikeMcQuaid reopened this Nov 2, 2017

MikeMcQuaid added some commits Oct 28, 2017

requirement: prepend rather than append PATH.
Otherwise this ends up behind e.g. `/usr/bin` so is pretty useless.
brew.rb: cleanup PATH setup.
Avoid adding all the tap commands to the PATH when not necessary.
requirement: don't add /usr/local/{bin,sbin}.
This should be considered a requirement bug if it's added.

@MikeMcQuaid MikeMcQuaid merged commit c6f40d5 into Homebrew:master Nov 3, 2017

3 checks passed

codecov/patch 83.33% of diff hit (target 69.19%)
Details
codecov/project 69.21% (+0.01%) compared to 4eeac6f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.