New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak use of with_env #3393

Merged
merged 1 commit into from Oct 30, 2017

Conversation

Projects
None yet
2 participants
@MikeMcQuaid
Member

MikeMcQuaid commented Oct 29, 2017

  • Use it in more places where it saves code
  • Allow using symbolic keys for a cleaner interface
  • Use HOMEBREW_GEM_* instead of GEM_OLD_*
Tweak use of with_env
- Use it in more places where it saves code
- Allow using symbolic keys for a cleaner interface
- Use `HOMEBREW_GEM_*` instead of `GEM_OLD_*`

@MikeMcQuaid MikeMcQuaid merged commit 7a0fdc3 into Homebrew:master Oct 30, 2017

2 of 3 checks passed

codecov/patch 65.21% of diff hit (target 68.49%)
Details
codecov/project 69.03% (+0.53%) compared to 9dbff4e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:with_env_tweaks branch Oct 30, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.