New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/sh: set working PS1 for zsh #3394

Merged
merged 1 commit into from Oct 29, 2017

Conversation

Projects
None yet
3 participants
@MikeMcQuaid
Member

MikeMcQuaid commented Oct 29, 2017

The default value is fine and this one is broken on zsh.

cmd/sh: set working PS1 for zsh.
The `bash`, default one is broken on `zsh`.

@MikeMcQuaid MikeMcQuaid changed the title from cmd/sh: don't set PS1. to cmd/sh: set working PS1 for zsh Oct 29, 2017

@MikeMcQuaid MikeMcQuaid merged commit 4c44266 into Homebrew:master Oct 29, 2017

2 of 3 checks passed

codecov/patch 0% of diff hit (target 68.66%)
Details
codecov/project 68.82% (+0.16%) compared to c59c0d6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:sh-no-ps1 branch Oct 29, 2017

@apjanke

This comment has been minimized.

Show comment
Hide comment
@apjanke

apjanke Nov 3, 2017

Contributor

Just for future reference: I suspect that the old prompt broke on zsh because recent changes to environment variable filtering caused PROMPT_SUBST to be unset in newly spawned zsh shells. It needs to be set to enable interpretation of \ sequences, and is off by default, but commonly enabled.

Contributor

apjanke commented Nov 3, 2017

Just for future reference: I suspect that the old prompt broke on zsh because recent changes to environment variable filtering caused PROMPT_SUBST to be unset in newly spawned zsh shells. It needs to be set to enable interpretation of \ sequences, and is off by default, but commonly enabled.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.