New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lines_cop: Update regex patterns to prevent false positives #3395

Merged
merged 1 commit into from Nov 3, 2017

Conversation

Projects
None yet
2 participants
@GauthamGoli
Member

GauthamGoli commented Oct 29, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

#3382 (comment)

@ilovezfs (or/and) @MikeMcQuaid I think there are more, but I'm not sure which one
Can you please checkout this PR locally and then run brew audit --only-cops=FormulaAudit/Miscellaneous and let me know which ones are false positives; I will update this PR with fixes.

@MikeMcQuaid MikeMcQuaid merged commit 872bd4f into Homebrew:master Nov 3, 2017

3 checks passed

codecov/patch 100% of diff hit (target 68.66%)
Details
codecov/project Absolute coverage decreased by -0.06% but relative coverage increased by +31.33% compared to c59c0d6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Nov 3, 2017

Member

Thanks again for this @GauthamGoli!

Member

MikeMcQuaid commented Nov 3, 2017

Thanks again for this @GauthamGoli!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.