New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalized words #3408

Merged
merged 2 commits into from Nov 8, 2017

Conversation

Projects
None yet
3 participants
@s-hfarooq
Contributor

s-hfarooq commented Nov 1, 2017

Capitalized beginning of each bullet point to match style of README.md

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Capitalized words
Capitalized beginning of each bullet point to match style of README.md
@reitermarkus

This comment has been minimized.

Show comment
Hide comment
@reitermarkus

reitermarkus Nov 1, 2017

Member

If these start with a capitalised word they should also end with a full stop, given they are full sentences.

Member

reitermarkus commented Nov 1, 2017

If these start with a capitalised word they should also end with a full stop, given they are full sentences.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Nov 3, 2017

Member

@s-hfarooq I agree with @reitermarkus, please address that, thanks.

Member

MikeMcQuaid commented Nov 3, 2017

@s-hfarooq I agree with @reitermarkus, please address that, thanks.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid
Member

MikeMcQuaid commented Nov 8, 2017

Thanks @s-hfarooq!

@MikeMcQuaid MikeMcQuaid merged commit 934480c into Homebrew:master Nov 8, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 302bc8b...1926f15
Details
codecov/project 69.19% (+1.02%) compared to 302bc8b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.