New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula: fix safe navigation bug #3414

Merged
merged 1 commit into from Nov 2, 2017

Conversation

Projects
None yet
3 participants
@ilovezfs
Contributor

ilovezfs commented Nov 2, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Safe navigation needs to be chained to preserve equivalence.

Fixes a bug introduced by 01e9ec9 in #3183.

CC @MikeMcQuaid @woodruffw

The symptom here is

==> Fetching patch 
Patch: https://github.com/Homebrew/homebrew-core/pull/20175.patch
==> Applying patch
Applying: dmd 2.077.0
==> Patch closes issue #20175
Warning: Nonstandard bump subject: dmd 2.077.0
Warning: Subject should be: dmd 2.077.0,  (devel)

which occurs any time a devel block is removed.

formula: fix safe navigation bug
Safe navigation needs to be chained to preserve equivalence.

Fixes a bug introduced by 01e9ec9 in #3183.
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Nov 2, 2017

Member

Oops, thanks for the fix!

Member

MikeMcQuaid commented Nov 2, 2017

Oops, thanks for the fix!

@ilovezfs ilovezfs merged commit 0ac5587 into Homebrew:master Nov 2, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 302bc8b...3769bcc
Details
codecov/project 69.16% (+0.99%) compared to 302bc8b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.